feat: Add Window UDFs to FFI Crate #16261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
logical-expr
29 tasks
alamb
approved these changes
Jun 5, 2025
There was a problem hiding this comment.
I reviewed the last three commits in this PR quickly and I think it looks like a good path forward. I am likely not going to be able to catch subtle bugs but I think for a first version to get started it is good to go.
I'll plan to rebase this PR up once #14775 is merged and we'll get this one in too
|
I rebased this PR on main so it was ready to go |
alamb
force-pushed
the
feat/ffi-window-udf
branch
from
5ac7a7e to
140e667
Compare
|
If the tests pass I'll merge it in |
github-actions
bot
removed
logical-expr
kosiew
pushed a commit
to kosiew/datafusion
that referenced
this pull request
Jun 9, 2025
* Initial commit of UDWF via FFI * Work in progress on integration testing of udwf * Rebase due to UDF changes upstream
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
This is the last part of the FFI UDFs that remain. It builds on top of #14775 so this PR looks larger than it really is.
What changes are included in this PR?
Are these changes tested?
Yes, including an end-to-end integration test.
Are there any user-facing changes?
None.