Optimize SortPreservingMergeStream to avoid SortKeyCursor sharing
#1624
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
tustvold
reviewed
Jan 21, 2022
Contributor
tustvold
left a comment
tustvold
left a comment
There was a problem hiding this comment.
I really like this change 👍
That being said I think it would be good to rename some things and update the corresponding comments to avoid future confusion. I also think it is possible to remove the Arc but I could be missing something...
Member
Author
alamb
approved these changes
Jan 22, 2022
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Looks like a great improvement to me 👍
Contributor
|
Thanks again @yjshen |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
This PR is based on #1596 so please review that one first.Rationale for this change
In
SortPreservingMergeStream,SortKeyCursorshouldn't be shared betweenmin_heapand output batch buffer. The current sharing leads to the use ofAtomicUsize, which may harm performance.What changes are included in this PR?
RecordBatchinstead ofSortKeyCursorfor output batch buffering.cursor_finishedto make sure each input stream is pulled after a resume fromPending.AtomicUsizefrom SortKeyCursor.Are there any user-facing changes?
No.