Skip to content

WIP: Test DataFusion with experimental Parquet Filter Pushdown #16222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

WIP: Test DataFusion with experimental Parquet Filter Pushdown #16222

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8b681e4
Pin to https://github.com/apache/arrow-rs/pull/7513
alamb May 29, 2025
8c54891
Update pin
alamb May 29, 2025
0edf8d1
Update pin
alamb May 29, 2025
c646027
Force pushdown filters to true
alamb Jun 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 19 additions & 44 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

30 changes: 30 additions & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,3 +218,33 @@ uninlined_format_args = "warn"
[workspace.lints.rust]
unexpected_cfgs = { level = "warn", check-cfg = ["cfg(tarpaulin)"] }
unused_qualifications = "deny"


# Patch to pull in https://github.com/apache/arrow-rs/pull/7513
[patch.crates-io]
arrow = { git = "https://github.com/alamb/arrow-rs.git", branch = "alamb/cache_filter_result" }
arrow-array = { git = "https://github.com/alamb/arrow-rs.git", branch = "alamb/cache_filter_result" }
arrow-buffer = { git = "https://github.com/alamb/arrow-rs.git", branch = "alamb/cache_filter_result" }
arrow-cast = { git = "https://github.com/alamb/arrow-rs.git", branch = "alamb/cache_filter_result" }
arrow-data = { git = "https://github.com/alamb/arrow-rs.git", branch = "alamb/cache_filter_result" }
arrow-ipc = { git = "https://github.com/alamb/arrow-rs.git", branch = "alamb/cache_filter_result" }
arrow-schema = { git = "https://github.com/alamb/arrow-rs.git", branch = "alamb/cache_filter_result" }
arrow-select = { git = "https://github.com/alamb/arrow-rs.git", branch = "alamb/cache_filter_result" }
arrow-string = { git = "https://github.com/alamb/arrow-rs.git", branch = "alamb/cache_filter_result" }
arrow-ord = { git = "https://github.com/alamb/arrow-rs.git", branch = "alamb/cache_filter_result" }
arrow-flight = { git = "https://github.com/alamb/arrow-rs.git", branch = "alamb/cache_filter_result" }
parquet = { git = "https://github.com/alamb/arrow-rs.git", branch = "alamb/cache_filter_result" }
# /Users/andrewlamb/Software/arrow-rs
#arrow = { path= "/Users/andrewlamb/Software/arrow-rs/arrow" }
#arrow-array = { path= "/Users/andrewlamb/Software/arrow-rs/arrow-array" }
#arrow-buffer = { path= "/Users/andrewlamb/Software/arrow-rs/arrow-buffer" }
#arrow-cast = { path= "/Users/andrewlamb/Software/arrow-rs/arrow-cast" }
#arrow-data = { path= "/Users/andrewlamb/Software/arrow-rs/arrow-data" }
#arrow-ipc = { path= "/Users/andrewlamb/Software/arrow-rs/arrow-ipc" }
#arrow-schema = { path= "/Users/andrewlamb/Software/arrow-rs/arrow-schema" }
#arrow-select = { path= "/Users/andrewlamb/Software/arrow-rs/arrow-select" }
#arrow-string = { path= "/Users/andrewlamb/Software/arrow-rs/arrow-string" }
#arrow-ord = { path= "/Users/andrewlamb/Software/arrow-rs/arrow-ord" }
#arrow-flight = { path= "/Users/andrewlamb/Software/arrow-rs/arrow-flight" }
#parquet = { path= "/Users/andrewlamb/Software/arrow-rs/parquet" }

2 changes: 2 additions & 0 deletions benchmarks/src/clickbench.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,8 @@ impl RunOpt {
// The hits_partitioned dataset specifies string columns
// as binary due to how it was written. Force it to strings
parquet_options.binary_as_string = true;
// TEST out impact of filter pushdown
parquet_options.pushdown_filters = true;
}

let rt_builder = self.common.runtime_env_builder()?;
Expand Down
Loading