Skip to content

Add change to VARCHAR in the upgrade guide #16216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 1, 2025

Conversation

alamb
Copy link
Contributor

@alamb alamb commented May 30, 2025

Which issue does this PR close?

Rationale for this change

Let's add some documentation to the upgrade guide about the change in #16142

What changes are included in this PR?

Upgrade guide updates

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added the documentation Improvements or additions to documentation label May 30, 2025
1 row(s) fetched.
Elapsed 0.004 seconds.
```

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @alamb , i think we also need to add note:

If customers use avro format, for datafusion 48.0, we need to set datafusion.sql_parser.map_varchar_to_utf8view = false;

Because the support for utf8view for avro are not releasing currently.

apache/arrow-rs#7262

Copy link
Contributor Author

@alamb alamb May 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Than you @zhuqi-lucas -- good call. Hopefully by the time we release Datafusion 48 the upstream supprt for avro will be released too.

Copy link
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks @alamb

I remember back then in Oracle days, there was VARCHAR and VARCHAR2 data types, just thinking aloud if it can be reused like VARCHAR is UTF8 ArrowType, VARCHAR2 is UTF8View

@zhuqi-lucas
Copy link
Contributor

lgtm thanks @alamb

I remember back then in Oracle days, there was VARCHAR and VARCHAR2 data types, just thinking aloud if it can be reused like VARCHAR is UTF8 ArrowType, VARCHAR2 is UTF8View

Interesting @comphead , we are currently have the option to disable it and fall back to UTF8:
set datafusion.sql_parser.map_varchar_to_utf8view = false;

But it seems if we also have the VARCHAR/VARCHAR2 , it's also a improvement from customer side. Thanks!

@alamb
Copy link
Contributor Author

alamb commented Jun 1, 2025

I remember back then in Oracle days, there was VARCHAR and VARCHAR2 data types, just thinking aloud if it can be reused like VARCHAR is UTF8 ArrowType, VARCHAR2 is UTF8View

Thanks @comphead -- this is an interesting idea. I think if there is strong demand to make it easier to distinguish between Utf8 and Utf8View it is worth pursuing that.

Co-authored-by: Oleks V <comphead@users.noreply.github.com>
@alamb alamb merged commit 5a86142 into apache:main Jun 1, 2025
5 checks passed
@alamb
Copy link
Contributor Author

alamb commented Jun 1, 2025

Had to merge this so we had at least one commit today 😅

@alamb alamb deleted the alamb/update_guide_utf8view branch June 1, 2025 16:49
@alamb
Copy link
Contributor Author

alamb commented Jun 1, 2025

Thanks @comphead and @zhuqi-lucas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants