minor: Add benchmark query and corresponding documentation for Average Duration #16105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @alamb |
logan-keede
changed the title
alamb
approved these changes
May 19, 2025
There was a problem hiding this comment.
Thank you @logan-keede -- this looks really nice to me. Can't wait to see how much faster this query is on #15748 from @shruti2522
cc @shruti2522
|
|
||
| **Question**: Which combinations of operating system, region, and user agent exhibit the highest average latency? For each of these combinations, also report the average response time. | ||
|
|
||
| **Important Query Properties**: Multiple average of Duration, high cardinality grouping |
There was a problem hiding this comment.
this is great -- thank you @logan-keede
| | 13631 | 82 | 45 | 0 days 7 hours 23 mins 1.000000000 secs | 0 days 7 hours 23 mins 1.000000000 secs | | ||
| +----------+-----------+-----+------------------------------------------+------------------------------------------+ | ||
| 10 row(s) fetched. | ||
| Elapsed 30.195 seconds. |
There was a problem hiding this comment.
oof -- love that it takes 30 seconds. The new accumulator will be so much faster
|
I am just running this quickly locally and then I'll merge it in |
./bench.sh run clickbench_extended
...
Q8: SELECT "RegionID", "UserAgent", "OS", AVG(to_timestamp("ResponseEndTiming")-to_timestamp("ResponseStartTiming")) as avg_response_time, AVG(to_timestamp("ResponseEndTiming")-to_timestamp("ConnectTiming")) as avg_latency FROM hits GROUP BY "RegionID", "UserAgent", "OS" ORDER BY avg_latency DESC limit 10;
Query 8 iteration 0 took 712.4 ms and returned 10 rows
Query 8 iteration 1 took 674.1 ms and returned 10 rows
Query 8 iteration 2 took 705.6 ms and returned 10 rows
Query 8 iteration 3 took 686.4 ms and returned 10 rows
Query 8 iteration 4 took 693.0 ms and returned 10 rows
Query 8 avg time: 694.29 ms
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Adds a query benchmark in extended queries of clickbench.
This query benchmarks performance of Average over Duration.
What changes are included in this PR?
Are these changes tested?
Yes, by Running them on my machine.
Are there any user-facing changes?
Nope.