[datafusion-spark] Add Spark-compatible char expression
#15994
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shehabgamin @alamb fyi |
|
Thank you for mention! ❤️ |
tlm365
reviewed
May 9, 2025
| fn chr(args: &[ArrayRef]) -> Result<ArrayRef> { | ||
| let integer_array = as_int64_array(&args[0])?; | ||
|
|
||
| // first map is the iterator, second is for the `Option<_>` |
alamb
approved these changes
May 16, 2025
|
Thanks @andygrove and @shehabgamin -- how close do you think we are to being able to open up the |
Ideally, I would like to wait for 48 release, upgrade Comet to use that and adopt the new expressions added so far to confirm all is ok, then I plan on writing an epic in Comet to convert all of our expressions from |
|
Makes sense to me 👍 |
jfahne
pushed a commit
to jfahne/datafusion
that referenced
this pull request
May 18, 2025
* Add Spark-compatible char expression * Add slt test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #15914
Rationale for this change
Add another Spark expression. This expression was originally contributed to Comet by @vaibhawvipul in apache/datafusion-comet#513
What changes are included in this PR?
Add new expression and tests
Are these changes tested?
Yes
Are there any user-facing changes?
No