Reduce rehashing cost for primitive grouping by also reusing hash value #15962

Rachelint · 2025-05-06T10:53:03Z

Which issue does this PR close?

Closes Reduce rehashing cost for primitive single group by #15961

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

Dandandan · 2025-05-06T10:56:24Z

I think the fn size(&self) -> usize { needs to take into account the u64 per element as well.

Rachelint · 2025-05-06T11:58:55Z

@alamb

alamb

Thanks @Rachelint -- I'll run the benchmarks

alamb · 2025-05-06T12:36:38Z

datafusion/physical-plan/src/aggregates/group_values/single_group_by/primitive.rs

@@ -85,7 +85,7 @@ pub struct GroupValuesPrimitive<T: ArrowPrimitiveType> {
    ///
    /// We don't store the hashes as hashing fixed width primitives
    /// is fast enough for this not to benefit performance
-    map: HashTable<usize>,
+    map: HashTable<(usize, u64)>,


it seems like the comment right above this line is no longer accurate and needs to be updated as this PR exactly saves the hashes

alamb · 2025-05-06T12:37:18Z

🤖 ./gh_compare_branch.sh Benchmark Script Running
Linux aal-dev 6.11.0-1013-gcp #13~24.04.1-Ubuntu SMP Wed Apr 2 16:34:16 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Comparing also-save-hash-in-single-primitive-group-by (ce1cdc8) to 6cc4953 diff
Benchmarks: tpch_mem clickbench_partitioned clickbench_extended
Results will be posted here when complete

alamb · 2025-05-06T13:11:12Z

🤖: Benchmark completed

Details

Comparing HEAD and also-save-hash-in-single-primitive-group-by
--------------------
Benchmark clickbench_extended.json
--------------------
┏━━━━━━━━━━━━━━┳━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓
┃ Query        ┃       HEAD ┃ also-save-hash-in-single-primitive-group-by ┃        Change ┃
┡━━━━━━━━━━━━━━╇━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩
│ QQuery 0     │  1978.70ms │                                   1923.71ms │     no change │
│ QQuery 1     │   762.68ms │                                    763.92ms │     no change │
│ QQuery 2     │  1508.41ms │                                   1504.61ms │     no change │
│ QQuery 3     │   729.53ms │                                    711.10ms │     no change │
│ QQuery 4     │  1486.52ms │                                   1448.45ms │     no change │
│ QQuery 5     │ 15898.00ms │                                  15220.31ms │     no change │
│ QQuery 6     │  2073.35ms │                                   2100.81ms │     no change │
│ QQuery 7     │  2651.66ms │                                   2081.88ms │ +1.27x faster │
└──────────────┴────────────┴─────────────────────────────────────────────┴───────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┓
┃ Benchmark Summary                                          ┃            ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━┩
│ Total Time (HEAD)                                          │ 27088.85ms │
│ Total Time (also-save-hash-in-single-primitive-group-by)   │ 25754.80ms │
│ Average Time (HEAD)                                        │  3386.11ms │
│ Average Time (also-save-hash-in-single-primitive-group-by) │  3219.35ms │
│ Queries Faster                                             │          1 │
│ Queries Slower                                             │          0 │
│ Queries with No Change                                     │          7 │
└────────────────────────────────────────────────────────────┴────────────┘
--------------------
Benchmark clickbench_partitioned.json
--------------------
┏━━━━━━━━━━━━━━┳━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓
┃ Query        ┃       HEAD ┃ also-save-hash-in-single-primitive-group-by ┃        Change ┃
┡━━━━━━━━━━━━━━╇━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩
│ QQuery 0     │     2.75ms │                                      2.76ms │     no change │
│ QQuery 1     │    36.49ms │                                     36.26ms │     no change │
│ QQuery 2     │    87.59ms │                                     89.10ms │     no change │
│ QQuery 3     │    97.98ms │                                    100.67ms │     no change │
│ QQuery 4     │   736.20ms │                                    603.66ms │ +1.22x faster │
│ QQuery 5     │   851.48ms │                                    855.12ms │     no change │
│ QQuery 6     │     2.30ms │                                      2.29ms │     no change │
│ QQuery 7     │    43.51ms │                                     42.21ms │     no change │
│ QQuery 8     │   893.84ms │                                    923.39ms │     no change │
│ QQuery 9     │  1194.01ms │                                   1250.21ms │     no change │
│ QQuery 10    │   263.16ms │                                    265.13ms │     no change │
│ QQuery 11    │   303.03ms │                                    306.12ms │     no change │
│ QQuery 12    │   917.79ms │                                    932.76ms │     no change │
│ QQuery 13    │  1307.63ms │                                   1267.14ms │     no change │
│ QQuery 14    │   847.68ms │                                    856.10ms │     no change │
│ QQuery 15    │  1036.05ms │                                    816.66ms │ +1.27x faster │
│ QQuery 16    │  1736.51ms │                                   1729.06ms │     no change │
│ QQuery 17    │  1621.31ms │                                   1609.06ms │     no change │
│ QQuery 18    │  3118.59ms │                                   3112.62ms │     no change │
│ QQuery 19    │    84.57ms │                                     84.84ms │     no change │
│ QQuery 20    │  1117.80ms │                                   1163.81ms │     no change │
│ QQuery 21    │  1316.19ms │                                   1352.65ms │     no change │
│ QQuery 22    │  2222.24ms │                                   2218.58ms │     no change │
│ QQuery 23    │  8440.36ms │                                   8586.15ms │     no change │
│ QQuery 24    │   469.14ms │                                    483.02ms │     no change │
│ QQuery 25    │   395.56ms │                                    410.38ms │     no change │
│ QQuery 26    │   542.54ms │                                    537.45ms │     no change │
│ QQuery 27    │  1601.59ms │                                   1637.57ms │     no change │
│ QQuery 28    │ 12796.81ms │                                  12636.74ms │     no change │
│ QQuery 29    │   539.78ms │                                    553.58ms │     no change │
│ QQuery 30    │   817.08ms │                                    840.11ms │     no change │
│ QQuery 31    │   861.21ms │                                    856.87ms │     no change │
│ QQuery 32    │  2668.88ms │                                   2668.61ms │     no change │
│ QQuery 33    │  3397.44ms │                                   3391.98ms │     no change │
│ QQuery 34    │  3394.85ms │                                   3406.81ms │     no change │
│ QQuery 35    │  1303.91ms │                                   1304.20ms │     no change │
│ QQuery 36    │   127.16ms │                                    123.85ms │     no change │
│ QQuery 37    │    61.48ms │                                     61.68ms │     no change │
│ QQuery 38    │   129.28ms │                                    127.65ms │     no change │
│ QQuery 39    │   206.08ms │                                    203.88ms │     no change │
│ QQuery 40    │    51.28ms │                                     51.33ms │     no change │
│ QQuery 41    │    47.18ms │                                     46.53ms │     no change │
│ QQuery 42    │    40.22ms │                                     39.79ms │     no change │
└──────────────┴────────────┴─────────────────────────────────────────────┴───────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┓
┃ Benchmark Summary                                          ┃            ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━┩
│ Total Time (HEAD)                                          │ 57730.50ms │
│ Total Time (also-save-hash-in-single-primitive-group-by)   │ 57588.36ms │
│ Average Time (HEAD)                                        │  1342.57ms │
│ Average Time (also-save-hash-in-single-primitive-group-by) │  1339.26ms │
│ Queries Faster                                             │          2 │
│ Queries Slower                                             │          0 │
│ Queries with No Change                                     │         41 │
└────────────────────────────────────────────────────────────┴────────────┘
--------------------
Benchmark tpch_mem_sf1.json
--------------------
┏━━━━━━━━━━━━━━┳━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━┓
┃ Query        ┃     HEAD ┃ also-save-hash-in-single-primitive-group-by ┃       Change ┃
┡━━━━━━━━━━━━━━╇━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━┩
│ QQuery 1     │ 124.28ms │                                    123.12ms │    no change │
│ QQuery 2     │  23.14ms │                                     24.17ms │    no change │
│ QQuery 3     │  35.52ms │                                     34.91ms │    no change │
│ QQuery 4     │  20.97ms │                                     21.04ms │    no change │
│ QQuery 5     │  55.43ms │                                     55.70ms │    no change │
│ QQuery 6     │  12.20ms │                                     12.07ms │    no change │
│ QQuery 7     │ 105.03ms │                                    105.01ms │    no change │
│ QQuery 8     │  27.15ms │                                     26.75ms │    no change │
│ QQuery 9     │  59.53ms │                                     62.81ms │ 1.06x slower │
│ QQuery 10    │  58.45ms │                                     57.11ms │    no change │
│ QQuery 11    │  13.30ms │                                     13.16ms │    no change │
│ QQuery 12    │  45.68ms │                                     45.96ms │    no change │
│ QQuery 13    │  29.81ms │                                     30.53ms │    no change │
│ QQuery 14    │  10.41ms │                                     10.01ms │    no change │
│ QQuery 15    │  26.04ms │                                     26.23ms │    no change │
│ QQuery 16    │  23.46ms │                                     22.34ms │    no change │
│ QQuery 17    │  98.40ms │                                     99.94ms │    no change │
│ QQuery 18    │ 243.17ms │                                    237.89ms │    no change │
│ QQuery 19    │  27.15ms │                                     28.75ms │ 1.06x slower │
│ QQuery 20    │  39.11ms │                                     38.82ms │    no change │
│ QQuery 21    │ 173.28ms │                                    170.09ms │    no change │
│ QQuery 22    │  17.43ms │                                     17.35ms │    no change │
└──────────────┴──────────┴─────────────────────────────────────────────┴──────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━┓
┃ Benchmark Summary                                          ┃           ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━┩
│ Total Time (HEAD)                                          │ 1268.96ms │
│ Total Time (also-save-hash-in-single-primitive-group-by)   │ 1263.75ms │
│ Average Time (HEAD)                                        │   57.68ms │
│ Average Time (also-save-hash-in-single-primitive-group-by) │   57.44ms │
│ Queries Faster                                             │         0 │
│ Queries Slower                                             │         2 │
│ Queries with No Change                                     │        20 │
└────────────────────────────────────────────────────────────┴───────────┘

Rachelint · 2025-05-06T13:21:06Z

I think the fn size(&self) -> usize { needs to take into account the u64 per element as well.

Addressed.

Rachelint · 2025-05-06T13:26:04Z

🤖: Benchmark completed
Details

Comparing HEAD and also-save-hash-in-single-primitive-group-by
--------------------
Benchmark clickbench_extended.json
--------------------
┏━━━━━━━━━━━━━━┳━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓
┃ Query        ┃       HEAD ┃ also-save-hash-in-single-primitive-group-by ┃        Change ┃
┡━━━━━━━━━━━━━━╇━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩
│ QQuery 0     │  1978.70ms │                                   1923.71ms │     no change │
│ QQuery 1     │   762.68ms │                                    763.92ms │     no change │
│ QQuery 2     │  1508.41ms │                                   1504.61ms │     no change │
│ QQuery 3     │   729.53ms │                                    711.10ms │     no change │
│ QQuery 4     │  1486.52ms │                                   1448.45ms │     no change │
│ QQuery 5     │ 15898.00ms │                                  15220.31ms │     no change │
│ QQuery 6     │  2073.35ms │                                   2100.81ms │     no change │
│ QQuery 7     │  2651.66ms │                                   2081.88ms │ +1.27x faster │
└──────────────┴────────────┴─────────────────────────────────────────────┴───────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┓
┃ Benchmark Summary                                          ┃            ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━┩
│ Total Time (HEAD)                                          │ 27088.85ms │
│ Total Time (also-save-hash-in-single-primitive-group-by)   │ 25754.80ms │
│ Average Time (HEAD)                                        │  3386.11ms │
│ Average Time (also-save-hash-in-single-primitive-group-by) │  3219.35ms │
│ Queries Faster                                             │          1 │
│ Queries Slower                                             │          0 │
│ Queries with No Change                                     │          7 │
└────────────────────────────────────────────────────────────┴────────────┘
--------------------
Benchmark clickbench_partitioned.json
--------------------
┏━━━━━━━━━━━━━━┳━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓
┃ Query        ┃       HEAD ┃ also-save-hash-in-single-primitive-group-by ┃        Change ┃
┡━━━━━━━━━━━━━━╇━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩
│ QQuery 0     │     2.75ms │                                      2.76ms │     no change │
│ QQuery 1     │    36.49ms │                                     36.26ms │     no change │
│ QQuery 2     │    87.59ms │                                     89.10ms │     no change │
│ QQuery 3     │    97.98ms │                                    100.67ms │     no change │
│ QQuery 4     │   736.20ms │                                    603.66ms │ +1.22x faster │
│ QQuery 5     │   851.48ms │                                    855.12ms │     no change │
│ QQuery 6     │     2.30ms │                                      2.29ms │     no change │
│ QQuery 7     │    43.51ms │                                     42.21ms │     no change │
│ QQuery 8     │   893.84ms │                                    923.39ms │     no change │
│ QQuery 9     │  1194.01ms │                                   1250.21ms │     no change │
│ QQuery 10    │   263.16ms │                                    265.13ms │     no change │
│ QQuery 11    │   303.03ms │                                    306.12ms │     no change │
│ QQuery 12    │   917.79ms │                                    932.76ms │     no change │
│ QQuery 13    │  1307.63ms │                                   1267.14ms │     no change │
│ QQuery 14    │   847.68ms │                                    856.10ms │     no change │
│ QQuery 15    │  1036.05ms │                                    816.66ms │ +1.27x faster │
│ QQuery 16    │  1736.51ms │                                   1729.06ms │     no change │
│ QQuery 17    │  1621.31ms │                                   1609.06ms │     no change │
│ QQuery 18    │  3118.59ms │                                   3112.62ms │     no change │
│ QQuery 19    │    84.57ms │                                     84.84ms │     no change │
│ QQuery 20    │  1117.80ms │                                   1163.81ms │     no change │
│ QQuery 21    │  1316.19ms │                                   1352.65ms │     no change │
│ QQuery 22    │  2222.24ms │                                   2218.58ms │     no change │
│ QQuery 23    │  8440.36ms │                                   8586.15ms │     no change │
│ QQuery 24    │   469.14ms │                                    483.02ms │     no change │
│ QQuery 25    │   395.56ms │                                    410.38ms │     no change │
│ QQuery 26    │   542.54ms │                                    537.45ms │     no change │
│ QQuery 27    │  1601.59ms │                                   1637.57ms │     no change │
│ QQuery 28    │ 12796.81ms │                                  12636.74ms │     no change │
│ QQuery 29    │   539.78ms │                                    553.58ms │     no change │
│ QQuery 30    │   817.08ms │                                    840.11ms │     no change │
│ QQuery 31    │   861.21ms │                                    856.87ms │     no change │
│ QQuery 32    │  2668.88ms │                                   2668.61ms │     no change │
│ QQuery 33    │  3397.44ms │                                   3391.98ms │     no change │
│ QQuery 34    │  3394.85ms │                                   3406.81ms │     no change │
│ QQuery 35    │  1303.91ms │                                   1304.20ms │     no change │
│ QQuery 36    │   127.16ms │                                    123.85ms │     no change │
│ QQuery 37    │    61.48ms │                                     61.68ms │     no change │
│ QQuery 38    │   129.28ms │                                    127.65ms │     no change │
│ QQuery 39    │   206.08ms │                                    203.88ms │     no change │
│ QQuery 40    │    51.28ms │                                     51.33ms │     no change │
│ QQuery 41    │    47.18ms │                                     46.53ms │     no change │
│ QQuery 42    │    40.22ms │                                     39.79ms │     no change │
└──────────────┴────────────┴─────────────────────────────────────────────┴───────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┓
┃ Benchmark Summary                                          ┃            ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━┩
│ Total Time (HEAD)                                          │ 57730.50ms │
│ Total Time (also-save-hash-in-single-primitive-group-by)   │ 57588.36ms │
│ Average Time (HEAD)                                        │  1342.57ms │
│ Average Time (also-save-hash-in-single-primitive-group-by) │  1339.26ms │
│ Queries Faster                                             │          2 │
│ Queries Slower                                             │          0 │
│ Queries with No Change                                     │         41 │
└────────────────────────────────────────────────────────────┴────────────┘
--------------------
Benchmark tpch_mem_sf1.json
--------------------
┏━━━━━━━━━━━━━━┳━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━┓
┃ Query        ┃     HEAD ┃ also-save-hash-in-single-primitive-group-by ┃       Change ┃
┡━━━━━━━━━━━━━━╇━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━┩
│ QQuery 1     │ 124.28ms │                                    123.12ms │    no change │
│ QQuery 2     │  23.14ms │                                     24.17ms │    no change │
│ QQuery 3     │  35.52ms │                                     34.91ms │    no change │
│ QQuery 4     │  20.97ms │                                     21.04ms │    no change │
│ QQuery 5     │  55.43ms │                                     55.70ms │    no change │
│ QQuery 6     │  12.20ms │                                     12.07ms │    no change │
│ QQuery 7     │ 105.03ms │                                    105.01ms │    no change │
│ QQuery 8     │  27.15ms │                                     26.75ms │    no change │
│ QQuery 9     │  59.53ms │                                     62.81ms │ 1.06x slower │
│ QQuery 10    │  58.45ms │                                     57.11ms │    no change │
│ QQuery 11    │  13.30ms │                                     13.16ms │    no change │
│ QQuery 12    │  45.68ms │                                     45.96ms │    no change │
│ QQuery 13    │  29.81ms │                                     30.53ms │    no change │
│ QQuery 14    │  10.41ms │                                     10.01ms │    no change │
│ QQuery 15    │  26.04ms │                                     26.23ms │    no change │
│ QQuery 16    │  23.46ms │                                     22.34ms │    no change │
│ QQuery 17    │  98.40ms │                                     99.94ms │    no change │
│ QQuery 18    │ 243.17ms │                                    237.89ms │    no change │
│ QQuery 19    │  27.15ms │                                     28.75ms │ 1.06x slower │
│ QQuery 20    │  39.11ms │                                     38.82ms │    no change │
│ QQuery 21    │ 173.28ms │                                    170.09ms │    no change │
│ QQuery 22    │  17.43ms │                                     17.35ms │    no change │
└──────────────┴──────────┴─────────────────────────────────────────────┴──────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━┓
┃ Benchmark Summary                                          ┃           ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━┩
│ Total Time (HEAD)                                          │ 1268.96ms │
│ Total Time (also-save-hash-in-single-primitive-group-by)   │ 1263.75ms │
│ Average Time (HEAD)                                        │   57.68ms │
│ Average Time (also-save-hash-in-single-primitive-group-by) │   57.44ms │
│ Queries Faster                                             │         0 │
│ Queries Slower                                             │         2 │
│ Queries with No Change                                     │        20 │
└────────────────────────────────────────────────────────────┴───────────┘

The result is as expected, the 3 fasters are all group by primitive + high cardinality.

alamb

Thank you @Rachelint and @Dandandan

also save hash in hashtable in primitive single group by.

ce1cdc8

Rachelint changed the title ~~Reduce rehashing cost for primitive single group by also saving hash value in hashtable~~ Reduce rehashing cost for primitive grouping by also saving hash value in hashtable May 6, 2025

Rachelint changed the title ~~Reduce rehashing cost for primitive grouping by also saving hash value in hashtable~~ Reduce rehashing cost for primitive grouping by also reusing hash value May 6, 2025

Rachelint mentioned this pull request May 6, 2025

Intermediate result blocked approach to aggregation memory management #15591

Draft

alamb reviewed May 6, 2025

View reviewed changes

Rachelint force-pushed the also-save-hash-in-single-primitive-group-by branch from d565b48 to 454e789 Compare May 6, 2025 13:20

address cr.

f2b5349

Rachelint force-pushed the also-save-hash-in-single-primitive-group-by branch from 454e789 to f2b5349 Compare May 6, 2025 13:23

alamb approved these changes May 6, 2025

View reviewed changes

Dandandan approved these changes May 6, 2025

View reviewed changes

Dandandan merged commit 6ce109b into apache:main May 6, 2025
27 checks passed

Rachelint deleted the also-save-hash-in-single-primitive-group-by branch May 7, 2025 03:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Reduce rehashing cost for primitive grouping by also reusing hash value #15962

Reduce rehashing cost for primitive grouping by also reusing hash value #15962

Uh oh!

Rachelint commented May 6, 2025

Uh oh!

Dandandan commented May 6, 2025

Uh oh!

Rachelint commented May 6, 2025

Uh oh!

alamb left a comment

Uh oh!

alamb May 6, 2025

Uh oh!

Rachelint May 6, 2025

Uh oh!

alamb commented May 6, 2025

Uh oh!

alamb commented May 6, 2025

Uh oh!

Rachelint commented May 6, 2025

Uh oh!

Rachelint commented May 6, 2025 •

edited

Loading

Uh oh!

alamb left a comment

Uh oh!

Uh oh!

Uh oh!

Reduce rehashing cost for primitive grouping by also reusing hash value #15962

Reduce rehashing cost for primitive grouping by also reusing hash value #15962

Uh oh!

Conversation

Rachelint commented May 6, 2025

Which issue does this PR close?

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

Uh oh!

Dandandan commented May 6, 2025

Uh oh!

Rachelint commented May 6, 2025

Uh oh!

alamb left a comment

Choose a reason for hiding this comment

Uh oh!

alamb May 6, 2025

Choose a reason for hiding this comment

Uh oh!

Rachelint May 6, 2025

Choose a reason for hiding this comment

Uh oh!

alamb commented May 6, 2025

Uh oh!

alamb commented May 6, 2025

Uh oh!

Rachelint commented May 6, 2025

Uh oh!

Rachelint commented May 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alamb left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Rachelint commented May 6, 2025 •

edited

Loading