Handle FixedSizeList in flatten #15899
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joroKr21
changed the title
Contributor
Contributor
Author
|
Whoops, I did not - I saw the comment on my merged PR and I went straight to fixing 😄 - should've checked first |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
flattenso it does only a level, not recursively #15160 which had a semantic merge conflictRationale for this change
Since the type signature of
flattenchange and is no longer recursive we need to handle the innerFixedSizeListexplicitly.What changes are included in this PR?
Are these changes tested?
The existing tests now pass.
Are there any user-facing changes?
No