Skip to content

deprecate schema expressions #15847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

ajita-asthana
Copy link

@ajita-asthana ajita-asthana commented Apr 25, 2025

Which issue does this PR close?

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added the common Related to common crate label Apr 25, 2025
Copy link
Contributor

@m09526 m09526 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In deprecation note, state the fully qualified path to the replacement method, i.e. ExprSchemable::to_field.

@alamb
Copy link
Contributor

alamb commented May 7, 2025

Marking as draft as I think this PR is no longer waiting on feedback and I am trying to clear review queue. Please mark it as ready for review when it is ready for another look

ajita-asthana and others added 4 commits May 7, 2025 20:18
Co-authored-by: Oleks V <comphead@users.noreply.github.com>
Co-authored-by: Oleks V <comphead@users.noreply.github.com>
Co-authored-by: Oleks V <comphead@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Related to common crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate ExprSchemable functions
4 participants