pipe column orderings into pruning predicate creation #15821
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
optimizer
adriangb
commented
Apr 23, 2025
Comment on lines
+303
to
+307
| let pruning_predicate = PruningPredicate::try_new( | ||
| Arc::clone(predicate), | ||
| self.schema(), | ||
| vec![ColumnOrdering::Unknown; self.schema().fields().len()], | ||
| )?; |
There was a problem hiding this comment.
We could add a new signature to avoid API churn, but I wanted to make it explicit for now to see all of the callsites
adriangb
force-pushed
the
column-orders-parquet-stats
branch
from
3e15afe to
8c2ceb1
Compare
|
@adriangb please check out pydantic#28 |
This was referenced Apr 29, 2025
24 tasks
18 tasks
etseidl
reviewed
May 20, 2025
| @@ -1566,6 +1599,50 @@ fn build_predicate_expression( | |||
| return expr; | |||
| } | |||
|
|
|||
| // Special handlng for floats. Because current Parquet statistics do not allow NaN, and | |||
There was a problem hiding this comment.
This block is why we need to get the column ordering info passed down. Here we know which column is being pruned and with which operation. For floats we can disallow pruning because the Parquet stats are incomplete. We can also skip pruning if the stats are not valid because an ordering is not defined for the type.
11 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NaNis present #15812