Remove redundant Precision combination code in favor of Precision::min/max/add
#15659
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
alamb
force-pushed
the
alamb/remove_replication
branch
from
0f10878 to
d818b17
Compare
alamb
commented
Apr 9, 2025
|
|
||
| /// If the given value is numerically greater than the original maximum value, | ||
| /// return the new maximum value with appropriate exactness information. | ||
| fn set_max_if_greater( |
There was a problem hiding this comment.
this code is the same as Precision::min and Precision::max, so we can avoid the duplication
alamb
force-pushed
the
alamb/remove_replication
branch
from
d818b17 to
ef8b5ea
Compare
alamb
force-pushed
the
alamb/remove_replication
branch
from
ef8b5ea to
7ac2c7a
Compare
alamb
changed the title
Precision combination code in favor of Precision::min/max/add
xudong963
approved these changes
Apr 10, 2025
|
Thanks @xudong963 and @jayzhan211 |
nirnayroy
pushed a commit
to nirnayroy/datafusion
that referenced
this pull request
May 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Precision::maxandset_max_if_greatermethods #15615Rationale for this change
We are trying to improve statistics handling (so we can use it more). It turns out that the code to aggregate statistics in ListingTable was repliated with code already present in Precision
What changes are included in this PR?
Are these changes tested?
By existing CI
Are there any user-facing changes?