Migrate datafusion/sql tests to insta, part2
#15499
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qstommyshu
changed the title
|
This PR does two things:
|
qstommyshu
changed the title
qstommyshu
changed the title
datafusion/sql tests to insta, part2
alamb
approved these changes
Apr 1, 2025
There was a problem hiding this comment.
This looks good to me -- thank you @qstommyshu -- very nice
| ); | ||
| } | ||
|
|
||
| #[test] | ||
| fn cast_to_invalid_decimal_type_precision_0() { | ||
| // precision == 0 | ||
| { |
There was a problem hiding this comment.
+1 for removing the uncessary level of nesting
There was a problem hiding this comment.
I was confused when looking at the code initially lol. I told myself, "Maybe this bracket has some use I don't know about" 🥲
|
FYI @blaginin |
|
Thanks again @qstommyshu |
This was referenced Apr 1, 2025
nirnayroy
pushed a commit
to nirnayroy/datafusion
that referenced
this pull request
May 2, 2025
* WIP: non-trivial cases migration * WIP: Fix projection expression in SQL integration test snapshot * clean up * rename `generate_plan` to `generate_logical_plan`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
datafusion/sqltests toinsta#15397, Migrate datafusion/sql tests to insta, part1 #15497 this is a part of Migrate datafusion/sql tests to insta,sql integrations #15484 breaking down.Rationale for this change
What changes are included in this PR?
This is the part 2 of #15484 breakdown, as the code changes in #15484 is too large. Part1: #15497
Are these changes tested?
Yes, I manually tested the before/after changes.
Are there any user-facing changes?
No