Support Accumulator for avg duration
#15468
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
sqllogictest
|
Ping @shruti2522 -- this one looks pretty close |
|
I think you need to update the signature of Avg to support the new type as well |
shruti2522
force-pushed
the
avg_duration
branch
from
051e33b to
bb16e43
Compare
shruti2522
force-pushed
the
avg_duration
branch
from
962cbfc to
a986491
Compare
@alamb this one's ready for review whenever you get a chance. |
alamb
reviewed
Apr 17, 2025
There was a problem hiding this comment.
Thank you very much @shruti2522 -- this code looks really nice. I think we need a few more tests but then it will be ready to merge
Thank you so much. This is great
| @@ -4969,6 +4969,25 @@ select count(distinct column1), count(distinct column2) from dict_test group by | |||
| statement ok | |||
| drop table dict_test; | |||
|
|
|||
| # avg_duartion | |||
There was a problem hiding this comment.
Suggested change
| # avg_duartion | |
| # avg_duration |
shruti2522
force-pushed
the
avg_duration
branch
from
b28ac9f to
8abc5b9
Compare
nirnayroy
pushed a commit
to nirnayroy/datafusion
that referenced
this pull request
May 2, 2025
* Support Accumulator for avg duration * Add tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
AVGfor durations #15458Rationale for this change
Enable support for averaging
DurationtypeWhat changes are included in this PR?
Added accumulator to compute the Avg of
Durationtypes, would add support forGroupsAccumulatorin a follow-up PR.Are these changes tested?
Yes.
Are there any user-facing changes?
Yes.