Skip to content

Conversation

@alamb
Copy link
Contributor

@alamb alamb commented Mar 27, 2025

Which issue does this PR close?

Rationale for this change

@danila-b made a workflow action to run extended tests in #15101 and I would like to make sure it documented

What changes are included in this PR?

Add a note in the contributor guide about how to run the tests

Are these changes tested?

Are there any user-facing changes?

@alamb alamb marked this pull request as ready for review March 27, 2025 19:22
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Mar 27, 2025
code works when there are hash collisions as well as running the relevant
portions of the entire [sqlite test suite].

You can run the extended tests on any PR by leaving the following comment (see [example here]):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so to run extended tests, is it optional or is it to rerun failed tests?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normally extended tests don't run on PRs, only after merges to main

If you want to run extended tests on a PR prior to merge, now you by leaving a Run extended test comment on the PR

Copy link
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks @alamb

@alamb alamb merged commit b4b8f64 into apache:main Mar 28, 2025
6 checks passed
@alamb
Copy link
Contributor Author

alamb commented Mar 28, 2025

Thanks @comphead and @xudong963

@alamb alamb deleted the alamb/testing_docs branch March 28, 2025 18:03
nirnayroy pushed a commit to nirnayroy/datafusion that referenced this pull request May 2, 2025
* Add documentation for `Run extended tests` command

* Update docs/source/contributor-guide/testing.md

---------

Co-authored-by: Oleks V <comphead@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants