Skip to content

Conversation

@logan-keede
Copy link
Contributor

@logan-keede logan-keede commented Mar 25, 2025

Which issue does this PR close?

  • None. just a small update to labeler.

Rationale for this change

labeler.yml does not include new datasource-* crates

What changes are included in this PR?

added datasource-* to labeler under datasource label. functions-* under functions label, and catalog-listing under catalog.

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added the development-process Related to development process of DataFusion label Mar 25, 2025
@github-actions github-actions bot added the datasource Changes to the datasource crate label Mar 25, 2025
@github-actions github-actions bot removed the datasource Changes to the datasource crate label Mar 25, 2025
@github-actions github-actions bot added the common Related to common crate label Mar 25, 2025
@github-actions github-actions bot removed the common Related to common crate label Mar 25, 2025
@logan-keede
Copy link
Contributor Author

logan-keede commented Mar 25, 2025

It needs to be merged first if #8431 this proves anything. 🤦‍♂️
let's wait for #15371. We are getting one more new crate Session.
do we want to have a separate label for session or just club it with catalog?

@logan-keede
Copy link
Contributor Author

session and wasmtest crates do not have any labels. Do we want one for them?

@logan-keede logan-keede marked this pull request as ready for review March 26, 2025 07:50
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me -- thank you @logan-keede

@alamb alamb merged commit 51b6a65 into apache:main Mar 26, 2025
28 checks passed
qstommyshu pushed a commit to qstommyshu/datafusion that referenced this pull request Mar 27, 2025
* Add new crates to labeler

* testing labeler

* testing labeler

* testing labeler

* testing labeler

* testing labeler

* testing labeler

* testing labeler

* testing labeler

* fixing

* adding to functions and catlog

* checking for path regex

* restore fixed
nirnayroy pushed a commit to nirnayroy/datafusion that referenced this pull request May 2, 2025
* Add new crates to labeler

* testing labeler

* testing labeler

* testing labeler

* testing labeler

* testing labeler

* testing labeler

* testing labeler

* testing labeler

* fixing

* adding to functions and catlog

* checking for path regex

* restore fixed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

development-process Related to development process of DataFusion

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants