Add downcast_to_source method for DataSourceExec
#15416
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
xudong963
commented
Mar 25, 2025
github-actions
bot
added
the
documentation
|
I added the change to the upgrading doc to let users find it easily: 4682fcd |
alamb
approved these changes
Mar 26, 2025
There was a problem hiding this comment.
Thanks @xudong963 -- I agree this is a nice improvement. I don't think we should mention this function in the 46 upgrade guide given that the function isn't available until 47
datafusion/datasource/src/source.rs
Outdated
| @@ -230,4 +231,18 @@ impl DataSourceExec { | |||
| Boundedness::Bounded, | |||
| ) | |||
| } | |||
|
|
|||
| /// Downcast the `DataSourceExec` to a specific file source | |||
There was a problem hiding this comment.
Suggested change
| /// Downcast the `DataSourceExec` to a specific file source | |
| /// Downcast the `DataSourceExec`'s `data_source` to a specific file source | |
| /// | |
| /// Returns `None` if | |
| /// 1. the datasource is not scanning files (`FileScanConfig`) | |
| /// 2. The [`FileScanConfig::file_source`] is not of type <T> |
| @@ -129,6 +129,20 @@ if let Some(datasource_exec) = plan.as_any().downcast_ref::<DataSourceExec>() { | |||
| # */ | |||
| ``` | |||
|
|
|||
| There's also a more convenient helper method `downcast_to_file_source` on `DataSourceExec` | |||
There was a problem hiding this comment.
This code will not be available until DataFusion 47, so we probably need to put this into a new heading for 47 upgrade guide
There was a problem hiding this comment.
Yes, i totally forgot that 🤦♂️
github-actions
bot
removed
the
documentation
39 tasks
|
@mertak-synnada @alamb Thanks for your review! |
qstommyshu
pushed a commit
to qstommyshu/datafusion
that referenced
this pull request
Mar 28, 2025
* Add downcast_to_source method for DataSourceExec * rename * fix conflicts * fix cippy * add the change to upgrading doc * prettier * remove * address comments
9 tasks
nirnayroy
pushed a commit
to nirnayroy/datafusion
that referenced
this pull request
May 2, 2025
* Add downcast_to_source method for DataSourceExec * rename * fix conflicts * fix cippy * add the change to upgrading doc * prettier * remove * address comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
When I upgraded the df46, It was annoying for me to do the following thing(a series of
downcast_ref) and it's also easy to call the wrong method, such as mixingfile_source()anddata_source():What changes are included in this PR?
Add the
downcast_to_sourcemethod forDataSourceExecto make life easyAre these changes tested?
Yes, I replace the existing code with the new method.
Are there any user-facing changes?
It'll be useful for users to upgrade df46.