-
Notifications
You must be signed in to change notification settings - Fork 1.8k
feat: Support serde for FileScanConfig batch_size
#15335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @westhide
Should we remove the batch_size from JSON source too?
| batch_size: Option<usize>, |
| reserved 10; | ||
|
|
||
| datafusion_common.Constraints constraints = 11; | ||
| optional uint32 batch_size = 12; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perhaps we can use uint64 as batch_size is a usize 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
0959545 to
27676a0
Compare
Can we add pub trait FileSource: Send + Sync {
/// Creates a `dyn FileOpener` based on given parameters
fn create_file_opener(
&self,
object_store: Arc<dyn ObjectStore>,
base_config: &FileScanConfig,
partition: usize,
) -> Arc<dyn FileOpener>;
// ...
} |
comphead
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which issue does this PR close?
Rationale for this change
Support serde for FileScanConfig
batch_sizedatafusion/datafusion/datasource/src/file_scan_config.rs
Lines 172 to 190 in 19dd46d
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?