chore(deps): Update sqlparser to 0.55.0 #15183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
sql
github-actions
bot
added
documentation
github-actions
bot
removed
documentation
|
Amazing! Thank you @PokIsemaine -- I'll try and review this sometime this week FYI @jonahgao |
jonahgao
reviewed
Mar 17, 2025
There was a problem hiding this comment.
Thank you @PokIsemaine. I reviewed part of the changes. I think some unwraps can be replaced with errors to prevent panic.
| @@ -216,8 +216,7 @@ impl<S: ContextProvider> SqlToRel<'_, S> { | |||
| pub(super) fn sql_case_identifier_to_expr( | |||
There was a problem hiding this comment.
Not related to this PR, why is it called case_identifier🤔
I'm not sure what the connection is between case and identifier.
jonahgao
approved these changes
Mar 21, 2025
| .map(|object_name_part| { | ||
| object_name_part | ||
| .as_ident() | ||
| .map_or_else(String::new, ident_to_string) |
There was a problem hiding this comment.
It might be better to return an error than to silently use a default value.
zhuqi-lucas
pushed a commit
to zhuqi-lucas/arrow-datafusion
that referenced
this pull request
Mar 24, 2025
* chore(deps): Update sqlparser to 0.55.0 * merge upstream * style: cargo fmt * fix: import * style: cargo fmt * fix: struct.slt, update.slt and lateral join * chore: cargo fmt & remove unwrap * fix: remove meaningless comment for rustfmt * refactor: plan_datafusion_err, remove clone * remove println --------- Co-authored-by: silezhou <zhousile2002@gmail.com> Co-authored-by: jonahgao <jonahgao@msn.com>
|
Thank you so much @jonahgao and @PokIsemaine |
qstommyshu
pushed a commit
to qstommyshu/datafusion
that referenced
this pull request
Mar 27, 2025
* chore(deps): Update sqlparser to 0.55.0 * merge upstream * style: cargo fmt * fix: import * style: cargo fmt * fix: struct.slt, update.slt and lateral join * chore: cargo fmt & remove unwrap * fix: remove meaningless comment for rustfmt * refactor: plan_datafusion_err, remove clone * remove println --------- Co-authored-by: silezhou <zhousile2002@gmail.com> Co-authored-by: jonahgao <jonahgao@msn.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Keep up with latest SQL parser dependencies
What changes are included in this PR?
Note
OrderBy: Add support for
ORDER BY ALLdatafusion-sqlparser-rs#1724I will create an issue for ORDER BY ALL and implement it later. Like
GROUP BY ALL, this requires obtaining select_exprs.struct.slt: user => user_infomation. I found that in the struct,useris parsed as aFunctionrather than anIdent.feat: Parse special keywords as functions (current_user, user, etc) datafusion-sqlparser-rs#561
update.slt: sqlparser already supports multiple tables in the UPDATE FROM clause, but DataFusion does not yet support it. Support multiple tables inUPDATE FROMclause datafusion-sqlparser-rs#1681ref
EXECUTE IMMEDIATEdatafusion-sqlparser-rs#1717BEGINdatafusion-sqlparser-rs#1718Are these changes tested?
Yes by CI
Are there any user-facing changes?