Deprecate Expr::Wildcard
#14959
Merged
Deprecate Expr::Wildcard
#14959
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
sql
shehabgamin
approved these changes
Mar 2, 2025
alamb
approved these changes
Mar 2, 2025
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Looks good to me -- thank you @linhr and @shehabgamin
Comment on lines
106
to
107
| // TODO: remove the next line after `Expr::Wildcard` is removed | ||
| #[allow(deprecated)] |
Contributor
There was a problem hiding this comment.
I think if you use expect(deprecated) here and below rather than allow(deprecated) the compiler will warn / error once we remove Expr::Wildcard (this is a trick I learned from @itsjunetime )
Suggested change
| // TODO: remove the next line after `Expr::Wildcard` is removed | |
| #[allow(deprecated)] | |
| #[expect(deprecated)] |
Contributor
Author
There was a problem hiding this comment.
Thanks @alamb! I've changed #[allow(deprecated)] to #[expect(deprecated)] in this PR.
Contributor
Author
There was a problem hiding this comment.
I kept the TODO comment in a few places to provide more context, when Expr::Wildcard is not directly referred to in the line following #[expect(deprecated)].
Contributor
|
I plan to make a PR to backport this change to |
xudong963
pushed a commit
to xudong963/arrow-datafusion
that referenced
this pull request
Mar 3, 2025
* Deprecate `Expr::Wildcard` * Update Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org> * Update --------- Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
xudong963
added a commit
that referenced
this pull request
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
This is discussed as part of #14123.
What changes are included in this PR?
Expr::Wildcardis marked as deprecated.Are these changes tested?
N/A
Are there any user-facing changes?
N/A