make DefaultSubstraitProducer public #14721
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
Feb 17, 2025
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Makes sense to me --thank you @gabotechs
Closed
Contributor
|
Yup, the DefaultSubstraitConsumer is already public so makes sense for this to be as well, I think 👍 thanks! |
xudong963
approved these changes
Feb 17, 2025
Contributor
|
Ah, yes it makes sense for this to be public. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
None
Rationale for this change
the DefaultSubstraitProducer should be available for datafusion_substrait users
What changes are included in this PR?
make DefaultSubstraitProducer public
Are these changes tested?
no behavior changes, it just makes a struct
pubNot sure why this was not public on the first place, if I'm missing some context please let me know