bug: Remove array_slice two arg variant #14527
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 3dfce7d I misunderstood an existing test and accidentally added a variant of `array_slice` that accepts two arguments. This variant is not valid and only works if one of the arguments are null. This commit fixes the problem by removing the two argument variant.
alamb
approved these changes
Feb 6, 2025
| [] [] | ||
|
|
||
| # array_slice scalar function #11 (with NULL-NULL) | ||
| query ?? |
Contributor
There was a problem hiding this comment.
This is consistent with duckdb too 👍
D select array_slice([1,2,3], null);
Binder Error: No function matches the given name and argument types 'array_slice(INTEGER[], "NULL")'. You might need to add explicit type casts.
Candidate functions:
array_slice(ANY, ANY, ANY) -> ANY
array_slice(ANY, ANY, ANY, BIGINT) -> ANY
LINE 1: select array_slice([1,2,3], null);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 3dfce7d I misunderstood an existing test and accidentally added a variant of
array_slicethat accepts two arguments. This variant is not valid and only works if one of the arguments are null. This commit fixes the problem by removing the two argument variant.Which issue does this PR close?
Related to #10548
Rationale for this change
Fixes a mistake in my previous RP.
Are these changes tested?
Yes
Are there any user-facing changes?
No