Skip to content

Conversation

@mbrobbel
Copy link
Member

@mbrobbel mbrobbel commented Feb 5, 2025

Which issue does this PR close?

error: use of a disallowed method `tokio::task::spawn`
  --> datafusion/sqllogictest/src/engines/postgres_engine/mod.rs:93:27
   |
93 |         let join_handle = tokio::spawn(async move {
   |                           ^^^^^^^^^^^^
   |
   = note: To provide cancel-safety, use `SpawnedTask::spawn` instead (https://github.com/apache/datafusion/issues/6513)
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#disallowed_methods
   = note: `-D clippy::disallowed-methods` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(clippy::disallowed_methods)]`

error: could not compile `datafusion-sqllogictest` (lib) due to 1 previous error

Rationale for this change

#14483 (comment)

What changes are included in this PR?

Use SpawnedTask::spawn instead of tokio::task::spawn.

Are these changes tested?

CI.

Are there any user-facing changes?

No.

@github-actions github-actions bot added the sqllogictest SQL Logic Tests (.slt) label Feb 5, 2025
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks (again) @mbrobbel

@alamb alamb added the development-process Related to development process of DataFusion label Feb 5, 2025
@alamb alamb merged commit e7e1a1d into apache:main Feb 5, 2025
26 checks passed
@mbrobbel mbrobbel deleted the fix-clippy-warning branch February 5, 2025 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

development-process Related to development process of DataFusion sqllogictest SQL Logic Tests (.slt)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants