refactor: switch BooleanBufferBuilder to NullBufferBuilder in sort function #14183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
Jan 18, 2025
There was a problem hiding this comment.
This is great -- thank you @Chen-Yuan-Lai
For anyone else watching this will avoid creating a null buffer on output if there were no nulls in the input 👍
|
Thanks again @Chen-Yuan-Lai |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nction
Which issue does this PR close?
Closes #14115 .
Rationale for this change
As mentioned in #14115 , several examples in DataFusion codebase still using
BooleanBufferBuilderrather thanNullBufferBuilder, they should be replaced withNullBufferBuilderfor optimization.What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?