Skip to content

feat: Use SchemaRef in JoinFilter #14182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 20, 2025
Merged

feat: Use SchemaRef in JoinFilter #14182

merged 6 commits into from
Jan 20, 2025

Conversation

@irenjj
Copy link
Contributor

@irenjj irenjj commented Jan 18, 2025

Which issue does this PR close?

Closes #14177

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added physical-expr Changes to the physical-expr crates optimizer Optimizer rules core Core DataFusion crate proto Related to proto crate labels Jan 18, 2025
alamb
alamb approved these changes Jan 18, 2025
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @irenjj and @jayzhan for the issue

I left some suggestions but I don't think they are required to merge. We could do them as a follow on PR

irenjj and others added 5 commits January 19, 2025 14:38
@irenjj @alamb
Update datafusion/core/src/physical_optimizer/projection_pushdown.rs
c4ad44d 
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
@irenjj @alamb
Update datafusion/physical-plan/src/joins/join_filter.rs
ad6d892 
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
@irenjj @alamb
Update datafusion/physical-plan/src/joins/join_filter.rs
938c2e5 
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
@irenjj @alamb
Update datafusion/physical-plan/src/joins/join_filter.rs
4eb2b8f 
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
@irenjj
fix
6dc9edf
@jayzhan211
Copy link
Contributor

jayzhan211 commented Jan 20, 2025

Thanks @irenjj @alamb

@jayzhan211 jayzhan211 merged commit 12c4c86 into apache:main Jan 20, 2025
25 checks passed
@irenjj irenjj deleted the schemaref_in_joinfilter branch January 20, 2025 11:08
@alamb
Copy link
Contributor

alamb commented Jan 22, 2025

🚀

@shehabgamin shehabgamin mentioned this pull request Feb 4, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alamb alamb alamb approved these changes

Assignees

No one assigned

Labels

core Core DataFusion crate optimizer Optimizer rules physical-expr Changes to the physical-expr crates proto Related to proto crate

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Use SchemaRef in JoinFilter

3 participants

@irenjj @jayzhan211 @alamb