-
Notifications
You must be signed in to change notification settings - Fork 1.8k
refactor: change some hashbrown RawTable uses to HashTable
#13514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is similar to `RawTableAllocExt` and will help apache#13256.
RawTable uses
alamb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good -- I am running benchmarks and will report back
I will run it again and see if it is reproducable |
|
I would be surprised if there's a notable difference, esp. for this change. Under the hood, it's basically all the same, see https://docs.rs/hashbrown/0.14.5/src/hashbrown/table.rs.html |
I agree - I just want to be sure |
|
I ran the benchmarks again and see no change. Thus I conclude this PR does not change performance significantly |
RawTable useshashbrown RawTable uses to HashTable
alamb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @crepererum
|
Thanks @crepererum @alamb |
Which issue does this PR close?
For #13256, but only parts of it.
Rationale for this change
Prepare
hashbrown0.15 upgrade.What changes are included in this PR?
HashTableAllocExtAre these changes tested?
Existing tests pass.
Are there any user-facing changes?
No.