Skip to content

collect table stats by default for listing table #1347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 23, 2021
Merged

collect table stats by default for listing table #1347

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
07bc2c7
collect table stats by default for listing table
houqp Nov 21, 2021
e660248
add test
houqp Nov 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion datafusion/src/datasource/listing/table.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ impl ListingOptions {
file_extension: String::new(),
format,
table_partition_cols: vec![],
collect_stat: false,
collect_stat: true,
target_partitions: 1,
}
}
Expand Down Expand Up @@ -303,6 +303,23 @@ mod tests {
Ok(())
}

#[tokio::test]
async fn load_table_stats_by_default() -> Result<()> {
let testdata = crate::test_util::parquet_test_data();
let filename = format!("{}/{}", testdata, "alltypes_plain.parquet");
let opt = ListingOptions::new(Arc::new(ParquetFormat::default()));
let schema = opt
.infer_schema(Arc::new(LocalFileSystem {}), &filename)
.await?;
let table =
ListingTable::new(Arc::new(LocalFileSystem {}), filename, schema, opt);
let exec = table.scan(&None, 1024, &[], None).await?;
assert_eq!(exec.statistics().num_rows, Some(8));
assert_eq!(exec.statistics().total_byte_size, Some(671));

Ok(())
}

#[tokio::test]
async fn read_empty_table() -> Result<()> {
let store = TestObjectStore::new_arc(&[("table/p1=v1/file.avro", 100)]);
Expand Down