Remove uses of #[allow(dead_code)] in favor of _identifier #13328
+25
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
physical-expr
|
lgtm |
comphead
reviewed
Nov 9, 2024
comphead
reviewed
Nov 11, 2024
| @@ -230,8 +230,7 @@ async fn main() -> Result<()> { | |||
| #[derive(Debug)] | |||
| pub struct IndexTableProvider { | |||
| /// Where the file is stored (cleanup on drop) | |||
There was a problem hiding this comment.
Suggested change
| /// Where the file is stored (cleanup on drop) | |
| /// Pointer to temporary file storage. Keeping it in scope to prevent temporary folder to be deleted prematurely |
comphead
reviewed
Nov 11, 2024
| @@ -362,8 +362,7 @@ impl TestFull { | |||
| // Holds necessary data for these tests to reuse the same parquet file | |||
| struct TestData { | |||
| // field is present as on drop the file is deleted | |||
There was a problem hiding this comment.
Suggested change
| // field is present as on drop the file is deleted | |
| /// Pointer to temporary file storage. Keeping it in scope to prevent temporary folder to be deleted prematurely |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #13278.
What changes are included in this PR?
This PR refactors instances where
#[allow(dead_code)]was used on struct fields that exist solely to ensure theirDrop(destructor) is called. In such cases, the field name has been updated to use an underscore prefix (e.g.,_name) instead of relying on#[allow(dead_code)]. This change aligns with idiomatic Rust practices, where _ prefixes indicate that fields or variables are intentionally unused but still necessary (e.g., memory reservation, tmp file cleanup in the source code).Are these changes tested?
Yes, in local environment.