Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor(docs): Add docs for regen.sh #13321

Merged
merged 1 commit into from
Nov 10, 2024
Merged

Conversation

jonathanc-n
Copy link
Contributor

Which issue does this PR close?

Closes #.

Rationale for this change

Mentioned in #13252,

What changes are included in this PR?

Moved the docs from the CONTRIBUTING.md in proto to also be included in howtos.

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Nov 9, 2024
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jonathanc-n ❤️

Copy link
Member

@Weijun-H Weijun-H left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @jonathanc-n 👍

@Weijun-H Weijun-H merged commit 221c85f into apache:main Nov 10, 2024
5 checks passed
@Weijun-H
Copy link
Member

Thanks @alamb for reviewing.

@jonathanc-n jonathanc-n deleted the add-doc-for-regen branch November 10, 2024 18:48
jayzhan211 pushed a commit to jayzhan211/datafusion that referenced this pull request Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants