Backport update to arrow 53.1.0 on branch-42 #12977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
changed the title
github-actions
bot
added
physical-expr
alamb
commented
Oct 16, 2024
| @@ -770,7 +770,7 @@ mod tests { | |||
| "c7: Int64", | |||
| "c8: Int64", | |||
| "c9: Int64", | |||
| "c10: Int64", | |||
| "c10: Utf8", | |||
There was a problem hiding this comment.
Changed due to arrow changes: https://github.com/apache/datafusion/pull/12724/files#r1785141290
| @@ -69,6 +69,7 @@ use parquet::arrow::arrow_writer::{ | |||
| use parquet::arrow::{ | |||
| arrow_to_parquet_schema, parquet_to_arrow_schema, AsyncArrowWriter, | |||
| }; | |||
| #[allow(deprecated)] | |||
There was a problem hiding this comment.
main has been updated to use the new APIs, but for the maintenance release let's just use the existing code
| @@ -87,13 +87,14 @@ mod test { | |||
|
|
|||
| wasm_bindgen_test::wasm_bindgen_test_configure!(run_in_browser); | |||
|
|
|||
| #[wasm_bindgen_test] | |||
| #[cfg_attr(target_arch = "wasm32", wasm_bindgen_test)] | |||
There was a problem hiding this comment.
these changes are from #12844, see rationale here
|
Merging this in to get clean CI runs for other backports and all the code has previously been approved / merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #12813
Rationale for this change
Clippy is failing on branch-42 after the arrow 53.1.0 upgrade. This was fixed in #12724 on main, but that also includes several other fixes
What changes are included in this PR?
53.1.0/ fix clippy #12724 to get CI passingAre these changes tested?
Are there any user-facing changes?