chore: make ParquetExec's with_file_groups public #12726
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI @alamb for your review |
alamb
reviewed
Oct 2, 2024
| @@ -586,7 +586,7 @@ impl ParquetExec { | |||
| ) | |||
| } | |||
|
|
|||
| fn with_file_groups(mut self, file_groups: Vec<Vec<PartitionedFile>>) -> Self { | |||
| pub fn with_file_groups(mut self, file_groups: Vec<Vec<PartitionedFile>>) -> Self { | |||
There was a problem hiding this comment.
I think the idea is that going forward we should use ParquetExecBuilder rather than the methods on ParquetExec itself.
Like can you use
let builder = ParquetExecBuilder::builder(exec.file_scan_config().clone())
.with_file_groups(...)
.build()There was a problem hiding this comment.
I think it will be easier to provide this
let builder = ParquetExecBuilder::builder_from_parquet_exec(parquet_exec)
.with_file_groups(...)
.build()The builder_from_parquet_exec is a new function
There was a problem hiding this comment.
I agree -- creating a builder from an existing ParquetExec would be helpful. I will try and make a PR for this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Make ParquetExec's
with_file_groupspublic so we can set it outside In InfluxDBWhat changes are included in this PR?
Add
pubin front of the said functionAre these changes tested?
I don't think the test is needed for making a function public unless I am told to do so. The compile is good enough to say it works or not
Are there any user-facing changes?
No