wip: converting rank builtin function to UDWF #12718
Draft
+746
−490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
logical-expr
jatin510
commented
Oct 2, 2024
| @@ -508,6 +508,9 @@ message ScalarUDFExprNode { | |||
| enum BuiltInWindowFunction { | |||
| UNSPECIFIED = 0; // https://protobuf.dev/programming-guides/dos-donts/#unspecified-enum | |||
| // ROW_NUMBER = 0; | |||
| // TODO | |||
| // if i will remove this | |||
| // should i renumber all variables? | |||
| RANK = 1; | |||
There was a problem hiding this comment.
@jcsherin how to handle this ?
I want to remove rank, percent_rank and dense_rank from here ?
There was a problem hiding this comment.
You just need to comment out the lines (not remove them):
enum BuiltInWindowFunction {
UNSPECIFIED = 0; // https://protobuf.dev/programming-guides/dos-donts/#unspecified-enum
// ROW_NUMBER = 0;
// RANK = 1;
// DENSE_RANK = 2;
// PERCENT_RANK = 3;
added 4 commits
October 2, 2024 20:31
…elated to Datafusion window function
…d updated pbson fields
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
#12648
Closes #.
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?