Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: upper case qualifier wildcard bug #12426

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Fix: upper case qualifier wildcard bug #12426

merged 1 commit into from
Sep 12, 2024

Conversation

JasonLi-cn
Copy link
Contributor

@JasonLi-cn JasonLi-cn commented Sep 11, 2024 •
edited
Loading

Which issue does this PR close?

Closes #12427

Rationale for this change

In order for the following query to work properly:

SELECT PUBLIC.t1.* FROM PUBLIC.t1

What changes are included in this PR?

Modify some SqlToRel functions:

  • sql_select_to_rex
  • sql_expr_to_logical_expr_internal

Using the object_name_to_table_reference function, to be consistent with create_relation.

Are these changes tested?

Yes.

Are there any user-facing changes?

@github-actions github-actions bot added sql SQL Planner sqllogictest SQL Logic Tests (.slt) labels Sep 11, 2024
alamb
alamb approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me -- thank you @JasonLi-cn

cc @jonahgao

jonahgao
jonahgao approved these changes Sep 12, 2024
View reviewed changes
Copy link
Member

@jonahgao jonahgao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@jonahgao jonahgao merged commit f7efd2d into apache:main Sep 12, 2024
26 checks passed
@JasonLi-cn JasonLi-cn mentioned this pull request Sep 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonahgao jonahgao jonahgao approved these changes

@alamb alamb alamb approved these changes

Assignees
No one assigned
Labels
sql SQL Planner sqllogictest SQL Logic Tests (.slt)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

upper case qualifier wildcard bug
3 participants
@JasonLi-cn @alamb @jonahgao