Skip to content

Replace Arc::try_unwrap with Arc::unwrap_or_clone where cloning anyway #12173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

findepi
Copy link
Member

@findepi findepi commented Aug 26, 2024

Extracted from #12166 + some more new places updated.
Relates to #12172

@github-actions github-actions bot added sql SQL Planner logical-expr Logical plan and expressions core Core DataFusion crate labels Aug 26, 2024
Copy link
Member

@jonahgao jonahgao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@findepi
Copy link
Member Author

findepi commented Aug 26, 2024

thank you @jonahgao for review!

@alamb alamb merged commit 0f96af5 into apache:main Aug 26, 2024
25 checks passed
@alamb
Copy link
Contributor

alamb commented Aug 26, 2024

Thanks @findepi and @jonahgao -- using the named function is clearly better in my opinion

@findepi findepi deleted the findepi/replace-arc-try-unwrap-with-arc-unwrap-or-clone-where-cloning-anyway-ca0bdc branch August 26, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate logical-expr Logical plan and expressions sql SQL Planner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants