Minor: inline unwrap_arc, rewrite_arc, rewrite_arcs #11005
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #5637
Closes #.
Rationale for this change
When profiling on main these functions show up many times
What changes are included in this PR?
Changes
Mark the functions as
#[inline(always)]
- I think they are not inlined without the#inline
attribute as they are in different cratesThis makes the profiles much easier to read and understand:
Are these changes tested?
Functionally by exisitng tests
Performance:
(performance measurements in progress)
Code size:
I also made sure this didn't bloat the binary size:
cd datafusion-cli cargo build --release
Before this PR:
TODO
After this PR:
TODO
Are there any user-facing changes?
Hopefuly