Minor: use venv in benchmark compare#10894
Merged
comphead merged 2 commits intoapache:mainfrom Jun 14, 2024
Merged
Conversation
Contributor
|
I merged up to get a clean CI run |
findepi
pushed a commit
to findepi/datafusion
that referenced
this pull request
Jul 16, 2024
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #10022
(Note: this PR follows up on #10070 which worked on the same issue but looks like got kinda stale)
Rationale for this change
Make it more convenient to run
bench.sh compareWhat changes are included in this PR?
Updates to bench.sh to include a new command
venv, and edit thecomparecommand to use the respectivevenvSeparates requirements.txt in case
compare.pywould ever need something elseAre these changes tested?
I tested by hand
./bench.sh compareand./bench.sh venv, in multiple scenarios:richinto system, and just run compareIn all cases compare works correctly.
Are there any user-facing changes?
No -- if the
compareworked for the user before, it will still do, regardless of whether they used venv or not.If it didn't work, then the user would see improved error message, run
./bench.sh venvwithout a need to configure any env var, and the new venv would be created in a gitignored folder in the repo