Add protobuf serde support for LogicalPlan::Unnest
#10681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrey Koshchiy <an.koshchiy@gmail.com>
alamb
reviewed
May 27, 2024
There was a problem hiding this comment.
thank you very much for this contribution @akoshchiy
I have started the CI tests on this PR. Once it passes this PR looks good to me 🚀
| @@ -524,6 +524,31 @@ async fn roundtrip_logical_plan_with_extension() -> Result<()> { | |||
| Ok(()) | |||
| } | |||
|
|
|||
| #[tokio::test] | |||
| async fn roundtrip_logical_plan_unnest() -> Result<()> { | |||
Signed-off-by: Andrey Koshchiy <an.koshchiy@gmail.com>
alamb
changed the title
Unnest
alamb
changed the title
UnnestLogicalPlan::Unnest
alamb
approved these changes
May 28, 2024
findepi
pushed a commit
to findepi/datafusion
that referenced
this pull request
Jul 16, 2024
Signed-off-by: Andrey Koshchiy <an.koshchiy@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #10639.
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Yes.
Are there any user-facing changes?
No.