Replace GetFieldAccess with indexing function in SqlToRel
#10375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
jayzhan211
commented
May 4, 2024
| host2 202 | ||
| host3 303 | ||
|
|
||
| # TODO: Issue tracked in https://github.com/apache/datafusion/issues/10364 |
Contributor
Author
There was a problem hiding this comment.
This is the issue from #10364, not a regression caused by this change.
jayzhan211
changed the title
GetFieldAccess with indexing function in parser
jayzhan211
changed the title
GetFieldAccess with indexing function in parserGetFieldAccess with indexing function in SqlToRel
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
Contributor
|
cc @westonpace |
alamb
approved these changes
May 13, 2024
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Looks good to me -- thank you @jayzhan211 -- I am going to also tag this PR as api change so it gets highlighted in the readme
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
Contributor
Author
|
Thanks @alamb ! |
This was referenced May 17, 2024
findepi
pushed a commit
to findepi/datafusion
that referenced
this pull request
Jul 16, 2024
…e#10375) * use func in parser Signed-off-by: jayzhan211 <jayzhan211@gmail.com> * add tests Signed-off-by: jayzhan211 <jayzhan211@gmail.com> * add test Signed-off-by: jayzhan211 <jayzhan211@gmail.com> * rm test1 Signed-off-by: jayzhan211 <jayzhan211@gmail.com> * parser done Signed-off-by: jayzhan211 <jayzhan211@gmail.com> * fmt Signed-off-by: jayzhan211 <jayzhan211@gmail.com> * fix exprapi test Signed-off-by: jayzhan211 <jayzhan211@gmail.com> * fix test Signed-off-by: jayzhan211 <jayzhan211@gmail.com> * fix conflicts Signed-off-by: jayzhan211 <jayzhan211@gmail.com> --------- Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #10374
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?