Skip to content

Conversation

@Jefffrey
Copy link
Contributor

Which issue does this PR close?

Closes #10106

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added the development-process Related to development process of DataFusion label Apr 16, 2024
@Jefffrey Jefffrey marked this pull request as ready for review April 16, 2024 22:06
# arrow is bumped manually
- dependency-name: "arrow*"
update-types: ["version-update:semver-major"]
- package-ecosystem: cargo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, but we mostly take the dependencies from datafusion?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I don't know if the check for datafusion is really needed

For arrow, it looks like cli does have an explicit dependency on it though:

https://github.com/apache/arrow-datafusion/blob/4ad4f90d86c57226a4e0fb1f79dfaaf0d404c273/datafusion-cli/Cargo.toml#L33

Copy link
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks @Jefffrey anyway we still have direct dependencies in cli

@Jefffrey Jefffrey merged commit ea53917 into apache:main Apr 17, 2024
@Jefffrey Jefffrey deleted the datafusion-cli-dependabot branch April 17, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

development-process Related to development process of DataFusion

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Configure dependabot to auto upgrade dependencies for datafusion-cli

2 participants