Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport to 37: make udf structs public #10107

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Apr 16, 2024

(note this targets branch-37, NOT main)

Which issue does this PR close?

Part of 37 maintenance release #9904

Rationale for this change

Backport fixes for regressions

What changes are included in this PR?

Backport #9903, fix for #9900 to branch-37

Are these changes tested?

N/A

* refactor: make all udf function impls public

* clippy
@alamb alamb marked this pull request as ready for review April 16, 2024 21:55
@alamb
Copy link
Contributor Author

alamb commented Apr 16, 2024

@Omega359 says

#9904 (comment)

Note that #9900 didn't in fact make all the udf's public - the string and unicode modules do not in fact have the modules changed to pub nor is default implemented for the functions that I spot checked.

@universalmind303 I wonder if you have time to confirm if this PR would help you or not

@alamb
Copy link
Contributor Author

alamb commented Apr 17, 2024

@andygrove do you happen to have time to review / approve this PR for the 37.1.0 release?

@alamb
Copy link
Contributor Author

alamb commented Apr 17, 2024

FYI @universalmind303

@alamb alamb merged commit 1f71d79 into apache:branch-37 Apr 17, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants