Skip to content

reduce usage of IntoIterator<Item = Expr> in logical plan builder window fn #372

@jimexist

Description

@jimexist

I am not sure we should use IntoIterator<Item = Expr> for every field with 6 fields. This will produce a version of the compiled function for every combination, which IMO adds an unnecessary compile time and binary size.

IntoIterator is more relevant when we want to avoid an extra allocation; these are very small vectors.

Originally posted by @jorgecarleitao in #334 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions