Skip to content

Consolidate various configurations options, remove unrelated batch_size #1565

@yjshen

Description

@yjshen

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

We currently have three Configurations: ExecutionConfig, PhysicalPlanConfig and RuntimeConfig. They all share batch_size, which is only meaningful for query execution.

As we get RuntimeEnv plumbing through all execute() methods, we've got RuntimeConfig available to all executing code. Therefore, we'd better consolidate these configs and better separate their responsibilities.

Describe the solution you'd like

  1. Keep the batch_size only in RuntimeConfig, remove all unrelated batch_size passing during query planning.
  2. Rename PhysicalPlanConfig to FileScanConfig that clarifies its usage scenario.

Describe alternatives you've considered

Additional context
#1526 (comment) as well for context.

Metadata

Metadata

Assignees

No one assigned

    Labels

    api changeChanges the API exposed to users of the crateenhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions