-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Closed
Labels
enhancementNew feature or requestNew feature or request
Description
Is your feature request related to a problem or challenge?
DataFusion has many rust features (e.g. --features=parquet) and recently we hit discovered several failures for features during refactoring
I reviewed the CI coverage and it is haphazard -- for example it was not clear were to add a test for #15124
Describe the solution you'd like
I would like CI coverage for all the feature flags in crates that datafusion users use
Describe alternatives you've considered
I suggest separate CI jobs for the different crates
crates:
datafusion-substraitdatafusion-protodatafusion-functionsdatafusion
For each of these crates, I would like a job that runs
cargo check --no-default-featurescargo check --no-default-features --features=<featurename>
Notes: this only runs cargo check (no need to actually create code)
Steps:
- Make per-crate jobs: Split out
datafusion-substraitanddatafusion-protoCI feature checks, increase coverage #15156 (review) - REview / add full feature flag coverage for
datafusion-functionscrate - REview / add full feature flag coverage for
datafusioncrate
Additional context
No response
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request