-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Open
Labels
development-processRelated to development process of DataFusionRelated to development process of DataFusion
Description
I wonder if should be checking more (or all) crates here?
datafusion/.github/workflows/rust.yml
Lines 594 to 641 in b8b0c55
| # Verify MSRV for the crates which are directly used by other projects: | |
| # - datafusion | |
| # - datafusion-substrait | |
| # - datafusion-proto | |
| # - datafusion-cli | |
| msrv: | |
| name: Verify MSRV (Min Supported Rust Version) | |
| runs-on: ubuntu-latest | |
| container: | |
| image: amd64/rust | |
| steps: | |
| - uses: actions/checkout@v4 | |
| - name: Setup Rust toolchain | |
| uses: ./.github/actions/setup-builder | |
| - name: Install cargo-msrv | |
| run: cargo install cargo-msrv | |
| - name: Check datafusion | |
| working-directory: datafusion/core | |
| run: | | |
| # If you encounter an error with any of the commands below it means | |
| # your code or some crate in the dependency tree has a higher MSRV | |
| # (Min Supported Rust Version) than the one specified in the | |
| # `rust-version` key of `Cargo.toml`. | |
| # | |
| # To reproduce: | |
| # 1. Install the version of Rust that is failing. Example: | |
| # rustup install 1.80.1 | |
| # 2. Run the command that failed with that version. Example: | |
| # cargo +1.80.1 check -p datafusion | |
| # | |
| # To resolve, either: | |
| # 1. Change your code to use older Rust features, | |
| # 2. Revert dependency update | |
| # 3. Update the MSRV version in `Cargo.toml` | |
| # | |
| # Please see the DataFusion Rust Version Compatibility Policy before | |
| # updating Cargo.toml. You may have to update the code instead. | |
| # https://github.com/apache/datafusion/blob/main/README.md#rust-version-compatibility-policy | |
| cargo msrv --output-format json --log-target stdout verify | |
| - name: Check datafusion-substrait | |
| working-directory: datafusion/substrait | |
| run: cargo msrv --output-format json --log-target stdout verify | |
| - name: Check datafusion-proto | |
| working-directory: datafusion/proto | |
| run: cargo msrv --output-format json --log-target stdout verify | |
| - name: Check datafusion-cli | |
| working-directory: datafusion-cli | |
| run: cargo msrv --output-format json --log-target stdout verify |
See arrow-rs PR for reference which identified a similar issue there: apache/arrow-rs#6742
Originally posted by @Jefffrey in #14009 (review)
alamb
Metadata
Metadata
Assignees
Labels
development-processRelated to development process of DataFusionRelated to development process of DataFusion