Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop copying LogicalPlan and Exprs in PushDownLimit #10292

Closed
alamb opened this issue Apr 29, 2024 · 6 comments · Fixed by #10508
Closed

Stop copying LogicalPlan and Exprs in PushDownLimit #10292

alamb opened this issue Apr 29, 2024 · 6 comments · Fixed by #10508
Assignees

Comments

@alamb
Copy link
Contributor

alamb commented Apr 29, 2024

Is your feature request related to a problem or challenge?

Part of #9637

As part of making the planner faster, we are updating the optimizer passes to avoid copying LogicalPlan and Expr (see #9637)

Describe the solution you'd like

I would like to reduce the amount of copying in this pass (even though it doesn't appear in current profiling)

Describe alternatives you've considered

Apply the model from @Lordworms in #10166 to this pass
2. Update OptimizerRule::supports_rewrite` to return true

  1. Update OptimizerRule to use rewrite
  2. Update the pass itself to not copy the LogicalPlan (ideally using the TreeNode API) - it is implemented for LogicalPlan (API) and Expr (API)

Other examples: #10218

Additional context

@kavirajk
Copy link
Contributor

kavirajk commented May 3, 2024

take

@alamb
Copy link
Contributor Author

alamb commented May 14, 2024

@kavirajk -- have you had a chance to work on this issue? If not, do you mind if someone else does?

@alamb
Copy link
Contributor Author

alamb commented May 14, 2024

I made #10501 to pull some of the code out into a function to maybe make this easier

@kavirajk
Copy link
Contributor

kavirajk commented May 14, 2024

@kavirajk -- have you had a chance to work on this issue? If not, do you mind if someone else does?

Sorry @alamb didn't get a chance to work on it unfortunately. Agree, feel free to work on it.

@kavirajk kavirajk removed their assignment May 14, 2024
@alamb
Copy link
Contributor Author

alamb commented May 14, 2024

No worries. Thanks @kavirajk

@alamb
Copy link
Contributor Author

alamb commented May 14, 2024

I bashed out a PR for this change this morning: #10508

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants