Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make all modules in function crate public, add Default impl's for all Func's #10164

Closed
Omega359 opened this issue Apr 21, 2024 · 1 comment · Fixed by #10239
Closed

Make all modules in function crate public, add Default impl's for all Func's #10164

Omega359 opened this issue Apr 21, 2024 · 1 comment · Fixed by #10239
Assignees
Labels
enhancement New feature or request

Comments

@Omega359
Copy link
Contributor

Is your feature request related to a problem or challenge?

Some of the modules in the functions crate are not public - primarily in the string and unicode modules - and do not follow the pattern set in #9903. As well, many of the Func's do not have a Default impl which should be added as well

Describe the solution you'd like

All modules that should be made public are public in the functions crate. All *Func's structs that are the basis for a ScalarUDFImpl should have Default impl's.

Describe alternatives you've considered

No response

Additional context

No response

@Omega359 Omega359 added the enhancement New feature or request label Apr 21, 2024
@Omega359
Copy link
Contributor Author

take

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant