Update extended tests with new results #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
Oct 16, 2025
| # Datafusion - Expected - NULL | ||
| skipif postgres | ||
| query error DataFusion error: Arrow error: Divide by zero error | ||
| query I rowsort label-9617 |
Contributor
Author
There was a problem hiding this comment.
it is pretty sweet to have the tests to generate the expected results
Contributor
Author
|
Once this PR is merged, I will make a PR to update the pin in datafusion to get the extended tests passing again |
Jefffrey
approved these changes
Oct 16, 2025
Contributor
Author
|
Thank you @Jefffrey |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of extended tests failures on main datafusion#18084
#17972 Restore case expr/expr optimisation while ensuring lazy evaluation datafusion#17973 supports conditional evaluation on some other expressions, so we need to update the sqlogictest s with the expected results