Allow array
to be used as a function name again
#432
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
#429 accidentally introduced a regression that found while testing downstream in DataFusion : apache/datafusion#1956
In particular, sql parser used to parse queries like this:
As a call to a function named
array
. However, after #429 it generates a parser error:SQL(ParserError("Expected [, found: ("))',
Changes
array(..)
as a function call.Note
array[]
is still parsed as an array expression.More details here #429 (comment)
cc @monadbobo