Skip to content

feat: support sqlite insert or statement #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 9, 2021
Merged

feat: support sqlite insert or statement #281

merged 1 commit into from
Feb 9, 2021

Conversation

zhangli-pear
Copy link
Contributor

@coveralls
Copy link

coveralls commented Nov 6, 2020

Pull Request Test Coverage Report for Build 546765859

  • 46 of 49 (93.88%) changed or added relevant lines in 3 files are covered.
  • 11 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.07%) to 90.023%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/ast/mod.rs 13 14 92.86%
src/parser.rs 15 16 93.75%
tests/sqlparser_common.rs 18 19 94.74%
Files with Coverage Reduction New Missed Lines %
src/parser.rs 1 86.2%
src/ast/mod.rs 10 71.75%
Totals Coverage Status
Change from base Build 545529532: -0.07%
Covered Lines: 5387
Relevant Lines: 5984

💛 - Coveralls

@Dandandan
Copy link
Contributor

Thanks for the contribution! I left a few comments :)

@zhangli-pear
Copy link
Contributor Author

I’v changed code following discussion above, please review again.BTW, how long does it take to publish a new version to crates.io?

@zhangli-pear
Copy link
Contributor Author

Is there anybody still following this thread?

@Dandandan
Copy link
Contributor

Thanks @zhangli-pear for building this feature.
Sorry for waiting so long to have a look at it.

@Dandandan
Copy link
Contributor

LGTM now @nickolay do you maybe have any comments?

@Dandandan
Copy link
Contributor

@zhangli-pear can you rebase against the main branch?

@zhangli-pear
Copy link
Contributor Author

Done. I didn't notice the conflict before😂.

@Dandandan
Copy link
Contributor

Thanks @zhangli-pear for the changes 👍

@Dandandan Dandandan merged commit add8991 into apache:main Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants