Add support for mysql's drop index (ALTER TABLE table_a DROP INDEX idx_a)
#1865
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…DROP INDEX idx_a`
|
Thanks @vimko! fyi there's a similar PR here for |
|
@iffyio Indeed, I didn't notice that. Thank you very much for reminding me. |
vimko
changed the title
DROP INDEX idx_a ON table_a and ALTER TABLE table_a DROP INDEX idx_a)ALTER TABLE table_a DROP INDEX idx_a)
iffyio
reviewed
Jun 6, 2025
Comment on lines
+192
to
+193
| /// Note: this is a [MySQL]-specific operation. | ||
| /// |
There was a problem hiding this comment.
Suggested change
| /// Note: this is a [MySQL]-specific operation. | |
| /// |
I think we can skip the note, since we're already linking to the mysql docs below
Comment on lines
+9135
to
+9137
| // MySql dialect doesn't support `DROP INDEX idx_a`,you need to specify a specific table, please refer: | ||
| // [MySql](https://dev.mysql.com/doc/refman/8.4/en/drop-index.html) | ||
| match all_dialects_except(|d| d.is::<MySqlDialect>()).verified_stmt(sql) { |
There was a problem hiding this comment.
not sure I followed the intent here, from the code in this PR the parser doesnt seem to have started rejecting any DROP INDEX statement variants specifically for mysql, so that I imagined these should still have been passing for mysql?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for mysql's drop index:
DROP INDEX idx_a ON table_aALTER TABLE table_a DROP INDEX idx_aAddresses #1863