Add supports for Hive's SELECT ... GROUP BY .. GROUPING SETS syntax
#1653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iffyio
reviewed
Jan 16, 2025
| /// Hive syntax: `SELECT ... GROUP BY .. GROUPING SETS` | ||
| /// | ||
| /// [Hive](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=30151323#EnhancedAggregation,Cube,GroupingandRollup-GROUPINGSETSclause) | ||
| pub grouping_sets: Option<Expr>, |
There was a problem hiding this comment.
I'm wondering is it possible to cover the lacking cases using the group_by property vs introducing a new property? Its not currently clear to me why a new field was introduced.
There was a problem hiding this comment.
Indeed, another idea is to attribute this situation to the group by property. It may be better. I will try to make it. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supports
SELECT ... GROUP BY .. GROUPING SETSsyntax for hive dialect. For more information, please refer to:https://cwiki.apache.org/confluence/display/Hive/Enhanced+Aggregation%2C+Cube%2C+Grouping+and+Rollup#EnhancedAggregation,Cube,GroupingandRollup-GROUPINGSETSclause
Also support hive
with rollup/cubeclause.This resolves issue #1644